Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang version to 1.16 #1687

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Mar 30, 2022

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 30, 2022
@k8s-ci-robot k8s-ci-robot requested review from bowei and prameshj March 30, 2022 17:49
@bowei
Copy link
Member

bowei commented Mar 30, 2022

Why not 1.18? Why 1.16 specifically.

@freehan
Copy link
Contributor Author

freehan commented Mar 30, 2022

No particular reason for 1.18. Mostly to align with k/k on using 1.16.

@bowei
Copy link
Member

bowei commented Mar 30, 2022

K/k has moved to 1.18 I think

@freehan freehan force-pushed the update-golang-version branch from 71e6dea to 04a8a62 Compare March 31, 2022 01:30
@freehan freehan force-pushed the update-golang-version branch from 04a8a62 to abe9653 Compare March 31, 2022 16:54
@freehan
Copy link
Contributor Author

freehan commented Mar 31, 2022

K/k has moved to 1.18 I think

No. It still uses 1.16
https://github.com/kubernetes/kubernetes/blob/master/go.mod#L9

@bowei
Copy link
Member

bowei commented Apr 1, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, freehan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0746d1b into kubernetes:master Apr 1, 2022
k8s-ci-robot added a commit that referenced this pull request Apr 5, 2022
[Cherrypick #1687 into release-1.16] upgrade golang version to 1.16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants