Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve RBS service deletion #1691

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Improve RBS service deletion #1691

merged 1 commit into from
Apr 8, 2022

Conversation

cezarygerard
Copy link
Contributor

@cezarygerard cezarygerard commented Apr 5, 2022 •
edited
Loading

In L4 RBS load balancer controller

  1. remove service annotations, for correct XLB->ILB transition when customer changes service annotations

  2. try to delete the instance group to cleanup the instance group, this will
      - succeed when the last Service/LB using the instance group is deleted
      - fail if other L4/L7 load balancer is using the instance group
    otherwise the IG can lea

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cezarygerard. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from bowei and freehan April 5, 2022 16:28
@bowei
Copy link
Member

bowei commented Apr 5, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2022
@bowei
Copy link
Member

bowei commented Apr 5, 2022

Can we add more details to the commit message regarding what this fixes

bowei
bowei reviewed Apr 5, 2022
View reviewed changes
pkg/l4lb/l4netlbcontroller.go Outdated Show resolved Hide resolved
bowei
bowei reviewed Apr 5, 2022
View reviewed changes
pkg/l4lb/l4netlbcontroller.go Outdated Show resolved Hide resolved
bowei
bowei reviewed Apr 5, 2022
View reviewed changes
pkg/l4lb/l4netlbcontroller.go Outdated Show resolved Hide resolved
@cezarygerard cezarygerard force-pushed the master branch 2 times, most recently from 5625455 to 5a0b3d5 Compare April 6, 2022 16:38
@bowei
Copy link
Member

bowei commented Apr 8, 2022

/assign

@cezarygerard
Improve service deletion:
504e974 
- remove service annotations to allow ILB<->XLB migration

- try to delete the instance group to cleanup the instance group, this will
  - succeed when the last Service/LB using the instance group is deleted
  - fail if other L4/L7 load balancer is using the instance group
otherwise the IG can leak
@cezarygerard
Copy link
Contributor Author

@bowei
all resolved

freehan
freehan approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@freehan freehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, freehan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 5fc5944 into kubernetes:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@freehan freehan freehan approved these changes

Assignees

@bowei bowei

@freehan freehan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cezarygerard @k8s-ci-robot @bowei @freehan