Fix BackendConfig.securityPolicy is not removed after config updates

[ruixiansong]

Fix issue #1706 BackendConfig.securityPolicy is not removed after config updates

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: songrx1997 / name: Ruixian Song (f5c88a5)

[k8s-ci-robot]

Welcome @songrx1997!

It looks like this is your first PR to kubernetes/ingress-gce 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-gce has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @songrx1997. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) or hashtag(#) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

• f5c88a5 Fix BackendConfig.securityPolicy is not removed after config updates #1706 BackendConfig.securityPolicy is not removed after config updates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ruixiansong]

/assign @swetharepakula

[swetharepakula]

/ok-to-test

[swetharepakula]

Thanks for the change Ruixian! My main comment is that we want to still be able to exit early if we see that no change needs to be done for security policy. Can you also add a unit test for this change?

[ruixiansong]

Hi @swetharepakula thanks for you comment.

Thanks for the change Ruixian! My main comment is that we want to still be able to exit early if we see that no change needs to be done for security policy.

For this, we need to know the desired security policy and current security policy. If they are different, we need to change the policy. Otherwise we do nothing and exit. So I think only after getting both the desired and current policy (line51) can we know whether changes need to be done.

Can you also add a unit test for this change?

Will do this, thanks for reminding!

[k8s-ci-robot]

Keywords which can automatically close issues and at(@) mentions are not allowed in the title of a Pull Request.

You can edit the title by writing /retitle in a comment.

When GitHub merges a Pull Request, the title is included in the merge commit. To avoid invalid keywords in the merge commit, please edit the title of the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[ruixiansong]

Add a new commit to update the test cases.

Added a new test case remove-policy-2 for the situation:
Current Backend Service with securityPolicy && BackendConfig without securityPolicy -> need to make a call to remove the policy. (This is the case in #1706 )

Removed no-specified-policy. We should make a call and remove the policy in this situation. So the case is no longer applicable.

[ruixiansong]

/retitle

[k8s-ci-robot]

@songrx1997: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[swetharepakula]

Few nits left. This is almost ready to merge. Thanks!

[spencerhance]

One possible scenario is that there is some customer who got stuck in this state accidentally and will be suprised when their policy is removed. That being said, it's probably a very rare occurrence given how important securityPolicy is.

[ruixiansong]

One possible scenario is that there is some customer who got stuck in this state accidentally and will be suprised when their policy is removed. That being said, it's probably a very rare occurrence given how important securityPolicy is.

Thanks @spencerhance Do you mean the situation that customers forget to put SecurityPolicy in the backendConfig and accidentally unset their security policy?

[swetharepakula]

Thanks for the change Ruixian!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: songrx1997, spencerhance, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [swetharepakula]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment