Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Custom Response Header Logic and the Unit Tests for it #1772

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Add Custom Response Header Logic and the Unit Tests for it #1772

merged 1 commit into from
Aug 30, 2022

Conversation

ruixiansong
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @songrx1997. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from bowei and freehan August 5, 2022 00:12
@ruixiansong
Copy link
Contributor Author

/assign @swetharepakula

@swetharepakula
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2022
swetharepakula
swetharepakula reviewed Aug 12, 2022
View reviewed changes
pkg/backends/features/customresponseheaders.go Outdated
@@ -0,0 +1,47 @@
/*
Copyright 2018 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change to 2022

@swetharepakula
Copy link
Member

Thanks for the change Ruixian!

A couple of small nits, otherwise lgtm! Please rebase on master and update the PR.

@spencerhance, please review as well. Thanks!

swetharepakula
swetharepakula reviewed Aug 12, 2022
View reviewed changes
pkg/backends/features/customresponseheaders.go Outdated
)

// EnsureCustomResponseHeaders reads the CustomResponseHeaders configuration specified in the ServicePort.BackendConfig
// and applies it to the BackendService. It returns true if there were difference between
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: there was a

pkg/backends/features/customresponseheaders_test.go Outdated
@@ -0,0 +1,99 @@
/*
Copyright 2019 The Kubernetes Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change to 2022

@ruixiansong ruixiansong force-pushed the customResponseHeaderLogic branch from 63d02cd to c843cfb Compare August 15, 2022 16:51
@ruixiansong
Copy link
Contributor Author

Thanks for the change Ruixian!

A couple of small nits, otherwise lgtm! Please rebase on master and update the PR.

@spencerhance, please review as well. Thanks!

Thanks @swetharepakula! Just updated the PR for nits.

@ruixiansong
Add controller logic for custom response headers
a63e41d 
adding unit test for custom response headers
@ruixiansong ruixiansong force-pushed the customResponseHeaderLogic branch from c843cfb to a63e41d Compare August 26, 2022 20:43
spencerhance
spencerhance approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@spencerhance spencerhance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @songrx1997!

Generally lgtm. We will have to be somewhat cautious in rolling this out since I think it will wipe out any existing response headers that somewhat has set manually. (Unsupported behavior but still a risk factor we've seen before).

@swetharepakula
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: songrx1997, spencerhance, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9143f66 into kubernetes:master Aug 30, 2022
@ridhoadya ridhoadya mentioned this pull request Oct 12, 2022
Closed
@ruixiansong ruixiansong deleted the customResponseHeaderLogic branch February 18, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

@spencerhance spencerhance spencerhance approved these changes

@bowei bowei Awaiting requested review from bowei

@freehan freehan Awaiting requested review from freehan

Assignees

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruixiansong @k8s-ci-robot @swetharepakula @spencerhance