fix for get NodePort from service spec #1773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kl52752 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @bowei |
k8s-ci-robot
added
size/S
k8s-ci-robot
added
size/M
panslava
reviewed
Aug 5, 2022
panslava
reviewed
Aug 5, 2022
panslava
reviewed
Aug 6, 2022
| @@ -80,6 +80,13 @@ func (r *L4NetLBSyncResult) SetMetricsForSuccessfulServiceSync() { | |||
| r.MetricsState.InSuccess = true | |||
| } | |||
|
|
|||
| func getNodePort(service *corev1.Service) int64 { | |||
There was a problem hiding this comment.
Should we add some condition if service is nil?
k8s-ci-robot
added
the
needs-rebase
|
@kl52752: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
service of type LoadBalancer has check that fields Spec.ports needs to be added but other type of services like ClusterIp does not have those requirements. To fix this issue we need to check is Spec.Ports array is not empty and it is good to check at the very beginning of
shouldProcessthat this service is of type LoadBalancer