ConfigMap informer should only watch --asm-configmap-based-config-nam… #1780
Conversation
…espace This avoids making total ConfigMap size part of the scalability profile of the controller. Testing: Manual - hack/run-local-glbc.sh --enable-asm-config-map-config \ -v=3 --asm-configmap-based-config-namespace=default - Created ConfigMaps in `default` namespace. - Observed only updates to the default namespace ConfigMaps were being observed in the controller. Notes One interesting thing to note is that watching kube-system has a non-trivial amount of constant activity due to leader election leases. This can cause CPU usage if there are a large number of components running leader election using the same namespace.
k8s-ci-robot
added
cncf-cla: yes
|
/assign @spencerhance @swetharepakula |
|
@bowei: GitHub didn't allow me to assign the following users: spencerhance. Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ConfigMap informer should only watch --asm-configmap-based-config-namespace
This avoids making total ConfigMap size part of the scalability
profile of the controller.
Testing: Manual
-v=3 --asm-configmap-based-config-namespace=default
defaultnamespace.observed in the controller.
Notes
One interesting thing to note is that watching kube-system has a
non-trivial amount of constant activity due to leader election leases.
This can cause CPU usage if there are a large number of components
running leader election using the same namespace.