Cleanup code #1791
Merged
Cleanup code #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
cezarygerard
force-pushed
the
never-use-l-as-variable-name
branch
from
826b038 to
0af506a
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/assign panslava |
panslava
suggested changes
Aug 26, 2022
pkg/loadbalancers/l4netlb_test.go
Outdated
| @@ -169,7 +169,7 @@ func TestHealthCheckFirewallDeletionWithILB(t *testing.T) { | |||
| l4NetLB := NewL4NetLB(netlbSvc, fakeGCE, meta.Regional, namer, record.NewFakeRecorder(100)) | |||
|
|
|||
| // make sure both ilb and netlb use the same l4 healtcheck instance | |||
| l4NetLB.l4HealthChecks = l4ilb.l4HealthChecks | |||
| l4NetLB.l4HealthChecks = l4ilb.healthChecks | |||
There was a problem hiding this comment.
if we change l4healthChecks -> healthChecks on ILB struct should we also change it on NetLB?
- get rid of one letter variables named 'L/l/I/|/!/1' - removed unused parameters from assert func in l4 tests no business logic or test logic has been changed in this commit
cezarygerard
force-pushed
the
never-use-l-as-variable-name
branch
from
0af506a to
28095d8
Compare
- get rid of one letter variables named 'L/l/I/|/!/1' - removed unused parameters from assert func in l4 tests - use better field names no business logic or test logic has been changed in this commit
|
@panslava I chave move the neg calculators refactoring to pr/1792 |
panslava
approved these changes
Aug 26, 2022
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup code:
no business logic or test logic has been changed in this commit