Refactor healthchecksl4, change functions order, rename functions #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
panslava
force-pushed
the
small-refactor-l4healthchecks
branch
from
a46af84 to
6e7e0f1
Compare
|
/assign kl52752 |
panslava
force-pushed
the
small-refactor-l4healthchecks
branch
4 times, most recently
from
d078f0c to
a06994c
Compare
panslava
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
panslava
force-pushed
the
small-refactor-l4healthchecks
branch
2 times, most recently
from
6488a06 to
b0cc6ff
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
kl52752
reviewed
Sep 13, 2022
| err := l4hc.hcProvider.Delete(hcName, scope) | ||
| if err != nil { | ||
| // Ignore deletion error due to health check in use by another resource. | ||
| if !utils.IsInUsedByError(err) { |
There was a problem hiding this comment.
maybe we should check the value of sharedHC to see if this error is really related to shared health check?
There was a problem hiding this comment.
I agree, that can be useful, but I don't want to change a lot of "logic" in this PR
Also, what if user decided to use our non-shared "healthcheck" for his own resources (which is weird case, but possible), so I am not sure, how we should act in this situation
panslava
force-pushed
the
small-refactor-l4healthchecks
branch
from
b0cc6ff to
004c214
Compare
k8s-ci-robot
added
size/L
panslava
force-pushed
the
small-refactor-l4healthchecks
branch
from
004c214 to
804528d
Compare
panslava
changed the title
- change functions order - extracted deleting health check to deleteHealthCheck function - rename EnsureHealthCheck -> EnsureHealthCheckWithFirewall, DeleteHealthCheck -> DeleteHealthCheckWithFirewall - removed unused return value from ensureHealthCheck
panslava
force-pushed
the
small-refactor-l4healthchecks
branch
from
804528d to
8b55dcc
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kl52752, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, just small refactoring
This is needed for Dual-Stack #1782, but doing this in separate PR