Fix errcheck linter for all non-test files #1813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @kl52752 |
kl52752
reviewed
Sep 14, 2022
cmd/fuzzer/fuzzer.go
Outdated
| default: | ||
| flag.Usage() | ||
| os.Exit(1) | ||
| } | ||
|
|
||
| // Suppress klog logging before flag.Parse() error. | ||
| flag.CommandLine.Parse([]string{}) | ||
| _ = flag.CommandLine.Parse([]string{}) |
There was a problem hiding this comment.
this hack does not make sense. Maybe you should disable Lint in this place?
There was a problem hiding this comment.
Disabled lint for .Parse
| @@ -132,7 +132,7 @@ func NewController(ctx *ControllerContext) *Controller { | |||
| } | |||
|
|
|||
| func (c *Controller) Run(stopCh <-chan struct{}) { | |||
| wait.PollUntil(5*time.Second, func() (bool, error) { | |||
| _ = wait.PollUntil(5*time.Second, func() (bool, error) { | |||
There was a problem hiding this comment.
as above maybe you should disable lint in this place
There was a problem hiding this comment.
Disabled lint for .PollUntil
panslava
force-pushed
the
fix-errcheck-for-prod-files
branch
2 times, most recently
from
0cd5282 to
ba263af
Compare
Add handling errors where it was missing
panslava
force-pushed
the
fix-errcheck-for-prod-files
branch
from
ba263af to
50fc64f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kl52752, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add handling errors where it was missing