Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log if health check intended shared on deletion #1815

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Log if health check intended shared on deletion #1815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/healthchecksl4/healthchecksl4.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ func (l4hc *l4HealthChecks) deleteHealthCheck(svc *corev1.Service, namer namer.L
klog.Errorf("Failed to delete healthcheck %s for service %s/%s - %v", hcName, svc.Namespace, svc.Name, err)
return false, err
}
klog.V(2).Infof("Failed to delete healthcheck %s: shared health check in use.", hcName)
klog.V(2).Infof("Failed to delete healthcheck %s is in use by other resource. Health check is shared in GKE = %t", hcName, sharedHC)
return false, nil
}
return true, nil
Expand Down