-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add L4 ILB Dual-Stack Metrics #1856
Add L4 ILB Dual-Stack Metrics #1856
Conversation
/assign cezarygerard |
Name: "number_of_l4_dual_stack_ilbs", | ||
Help: "Number of L4 ILBs with DualStack enabled", | ||
}, | ||
[]string{"ipFamilies", "ipFamilyPolicy", "status"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the old metrics with new labels?
adding labels is a safe change
l4ILBCount = prometheus.NewGaugeVec(
prometheus.GaugeOpts{
Name: "number_of_l4_ilbs",
Help: "Number of L4 ILBs",
},
[]string{label, "ipFamilies", "ipFamilyPolicy", "status"},
)
or this is not possible with a feature label?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR adds counting service per ipFamilies, ipFamilyPolicy and Status for L4 ILB DualStack
Count will be stored in a map where key is struct