Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L4 ILB Dual-Stack Metrics #1856

Merged

Conversation

panslava
Copy link
Contributor

@panslava panslava commented Nov 8, 2022

This PR adds counting service per ipFamilies, ipFamilyPolicy and Status for L4 ILB DualStack

Count will be stored in a map where key is struct

type L4ILBDualStackServiceState struct {
	// IPFamilies stores spec.ipFamilies of Service
	IPFamilies string
	// IPFamilyPolicy specifies spec.IPFamilyPolicy of Service
	IPFamilyPolicy string
	// Status specifies status of L4 ILB DualStack
	Status L4ILBDualStackServiceStateStatus
}

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2022
@panslava panslava marked this pull request as draft November 8, 2022 11:39
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2022
@panslava panslava marked this pull request as ready for review November 8, 2022 13:35
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot requested a review from bowei November 8, 2022 13:35
@panslava
Copy link
Contributor Author

panslava commented Nov 8, 2022

/assign cezarygerard

Name: "number_of_l4_dual_stack_ilbs",
Help: "Number of L4 ILBs with DualStack enabled",
},
[]string{"ipFamilies", "ipFamilyPolicy", "status"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use the old metrics with new labels?
adding labels is a safe change

l4ILBCount = prometheus.NewGaugeVec(
	prometheus.GaugeOpts{
		Name: "number_of_l4_ilbs",
		Help: "Number of L4 ILBs",
	},
	[]string{label, "ipFamilies", "ipFamilyPolicy", "status"},
)

or this is not possible with a feature label?

@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cezarygerard,panslava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit da6d3c1 into kubernetes:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants