Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metrics for syncer states #1912

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Add metrics for syncer states #1912

merged 1 commit into from
Feb 28, 2023

Conversation

sawsa307
Copy link
Contributor

Added metrics to collect the current count of syncers in each status.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 24, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and MrHohn January 24, 2023 22:57
@sawsa307
Copy link
Contributor Author

/assign @swetharepakula

@aojea
Copy link
Member

aojea commented Jan 25, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 25, 2023
@sawsa307
Copy link
Contributor Author

/retest

1 similar comment
@aojea
Copy link
Member

aojea commented Jan 25, 2023

/retest

@aojea
Copy link
Member

aojea commented Jan 25, 2023

/test pull-ingress-gce-verify

@sawsa307 sawsa307 force-pushed the neg-syncer-status-metric branch 11 times, most recently from 490817c to e137fdc Compare February 2, 2023 00:30
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 2, 2023
@sawsa307 sawsa307 force-pushed the neg-syncer-status-metric branch from e137fdc to ca9d8a4 Compare February 2, 2023 01:19
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 2, 2023
@sawsa307 sawsa307 marked this pull request as draft February 4, 2023 05:51
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2023
@sawsa307 sawsa307 force-pushed the neg-syncer-status-metric branch from ca9d8a4 to b0b0442 Compare February 15, 2023 18:44
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 15, 2023
@sawsa307 sawsa307 marked this pull request as ready for review February 15, 2023 18:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2023
@k8s-ci-robot k8s-ci-robot requested a review from thockin February 15, 2023 18:45
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 17, 2023
@sawsa307 sawsa307 force-pushed the neg-syncer-status-metric branch from b0b0442 to 3bc44b3 Compare February 17, 2023 09:36
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 17, 2023
@sawsa307 sawsa307 force-pushed the neg-syncer-status-metric branch from 3bc44b3 to 6a87f4d Compare February 27, 2023 22:25
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2023
swetharepakula
swetharepakula reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, otherwise ready to be merged

pkg/neg/metrics/neg_metrics_collector.go Outdated
@@ -39,6 +42,16 @@ var (
},
[]string{syncResultLabel},
)

// syncerSyncerStatus tracks the count of syncer in different statuses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: different states

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Thanks!

@sawsa307 sawsa307 force-pushed the neg-syncer-status-metric branch from 6a87f4d to bdf4672 Compare February 27, 2023 23:29
@sawsa307 sawsa307 changed the title Add metrics for syncer status Add metrics for syncer states Feb 27, 2023
@sawsa307
Add metrics for syncer status
8e98ff7 
Added metrics to collect the current count of syncers in each status.
@sawsa307 sawsa307 force-pushed the neg-syncer-status-metric branch from bdf4672 to 8e98ff7 Compare February 27, 2023 23:32
swetharepakula
swetharepakula reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sawsa307, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 43c5522 into kubernetes:master Feb 28, 2023
@sawsa307 sawsa307 mentioned this pull request Feb 28, 2023
Merged
@sawsa307 sawsa307 deleted the neg-syncer-status-metric branch September 2, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

@aojea aojea Awaiting requested review from aojea

@MrHohn MrHohn Awaiting requested review from MrHohn

@thockin thockin Awaiting requested review from thockin

Assignees

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sawsa307 @k8s-ci-robot @aojea @swetharepakula