Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create NEG metrics collector interface #1932

Merged

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Feb 3, 2023

Create NEG metrics collector that would periodically emit NEG syncer metrics.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from aojea and freehan February 3, 2023 17:32
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 3, 2023
@sawsa307 sawsa307 force-pushed the neg-metrics-collector-interface branch from 12a7dee to b5315cb Compare February 3, 2023 17:52
@sawsa307
Copy link
Contributor Author

sawsa307 commented Feb 3, 2023

/assign @swetharepakula

@sawsa307 sawsa307 force-pushed the neg-metrics-collector-interface branch from b5315cb to cf7b81a Compare February 3, 2023 18:09
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sawsa307
Once this PR has been reviewed and has the lgtm label, please ask for approval from swetharepakula by writing /assign @swetharepakula in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sawsa307 sawsa307 force-pushed the neg-metrics-collector-interface branch from cf7b81a to edb1502 Compare February 3, 2023 19:55
@sawsa307 sawsa307 changed the title Create NEG metrics controller interface Create NEG metrics collector interface Feb 3, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 3, 2023
Create NEG metris collector that would periodically emits NEG syncer
metrics.
@sawsa307 sawsa307 force-pushed the neg-metrics-collector-interface branch from edb1502 to 3926dfc Compare February 5, 2023 01:48
@bowei
Copy link
Member

bowei commented Feb 9, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3926dfc into kubernetes:master Feb 13, 2023
@sawsa307 sawsa307 deleted the neg-metrics-collector-interface branch September 2, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants