Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherry pick #1926] Remove Services.Get() from syncNegStatusAnnotation() #1942

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

cezarygerard
Copy link
Contributor

@cezarygerard cezarygerard commented Feb 10, 2023

Cherry pick from #1926

Optimize Neg Controller

Note:
I have created this cherry pick MANUALLY from PR/1926 as it is almost impossible to use merge tools after code has diverged so far

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 10, 2023
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2023
@k8s-ci-robot
Copy link
Contributor

@cezarygerard: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress-gce-verify 57e8c80 link true /test pull-ingress-gce-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cezarygerard cezarygerard changed the title Remove Services.Get() from syncNegStatusAnnotation() [Cherry pick #1926] Remove Services.Get() from syncNegStatusAnnotation() Feb 10, 2023
@cezarygerard
Copy link
Contributor Author

/retest

@cezarygerard
Copy link
Contributor Author

/test pull-ingress-gce-verify

@k8s-ci-robot
Copy link
Contributor

@cezarygerard: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-ingress-gce-test

Use /test all to run all jobs.

In response to this:

/test pull-ingress-gce-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cezarygerard
Copy link
Contributor Author

/test all

@aojea
Copy link
Member

aojea commented Feb 10, 2023

/retest

@aojea
Copy link
Member

aojea commented Feb 10, 2023

/test pull-ingress-gce-verify

@k8s-ci-robot
Copy link
Contributor

@aojea: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-ingress-gce-test

Use /test all to run all jobs.

In response to this:

/test pull-ingress-gce-verify

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cezarygerard
Copy link
Contributor Author

/test all

Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2023
@aojea
Copy link
Member

aojea commented Feb 13, 2023

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@aojea
Copy link
Member

aojea commented Feb 13, 2023

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, cezarygerard, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cezarygerard,swetharepakula]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9cea723 into kubernetes:release-1.20 Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants