-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump kubernetes dependencies to 1.26.1 #1969
Conversation
/assign @swetharepakula @cezarygerard /priority important-soon |
@aojea: GitHub didn't allow me to request PR reviews from the following users: mmamczur. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority important-soon |
@aojea: GitHub didn't allow me to assign the following users: spencerhance. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
lgtm overall |
@@ -1,78 +1,79 @@ | |||
module k8s.io/ingress-gce | |||
|
|||
go 1.18 | |||
go 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be 1.20?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
go directive
A go directive indicates that a module was written assuming the semantics of a given version of Go. The version must be a valid Go release version: a positive integer followed by a dot and a non-negative integer (for example, 1.9, 1.14).
it was to be conservative and not make a big jump
Thank you for this change! This looks good to me. The only question I had was whether we should regenerate go.mod with Go 1.20. But I think that doesn't need to keep this PR from merging. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Current version of the Kubernetes APIs is too old 1.20
Update the repo to latest stable version Kubernetes 1.26.1
There was necessary to adapt the codebase:
apimachinery/clock
library tok8s.io/utils/clock
Prepare clock package to be compatible replacement of apimachinery/util/clock utils#224 in thepkg/neg
folderk8s.io/client-go/tools/cache/cache.SharedInformer.AddEventHandler