Concurrently process deletion candidates within NEG Garbage Collector #1976
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @gauravkghildiyal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
gauravkghildiyal
force-pushed
the
concurrent-neg-gc
branch
4 times, most recently
from
4663faa to
4111167
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
pkg/neg/manager.go
Outdated
| // deleteNegOrReportErr will attempt to delete the specified NEG resource in the cloud. If an error | ||
| // occurs, it will report an error as an event on the given CR. If an error does occur, false will | ||
| // be returned to indicate that the CR should not be deleted. | ||
| deleteNegOrReportErr := func(name, zone string, cr *negv1beta1.ServiceNetworkEndpointGroup) bool { | ||
| deleteNegOrReportErr := func(name, zone string, svcNegCR *negv1beta1.ServiceNetworkEndpointGroup) bool { |
There was a problem hiding this comment.
nit: pull this out into its own function as we will be recreating this function once per service and there is no special context in the function itself.
pkg/neg/manager.go
Outdated
| if err := deleteSvcNegCR(manager.svcNegClient, cr, manager.logger); err != nil { | ||
| errList = append(errList, err) | ||
| // Verify that the NEG is still not wanted before deleting the CR. Mitigates the possibility of the race | ||
| // condition mentioned above |
There was a problem hiding this comment.
nit: since the comment is now in a different function, point to the preceding function
gauravkghildiyal
force-pushed
the
concurrent-neg-gc
branch
from
4111167 to
c3164a7
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
…elease-1.22 [Cherry pick #1976] Concurrently process deletion candidates within NEG Garbage Collector
/assign @swetharepakula