-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smaller bucket sizes for workqueue metrics #1981
Add smaller bucket sizes for workqueue metrics #1981
Conversation
Hi @gauravkghildiyal. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @swetharepakula |
42d0a04
to
c285121
Compare
This seems reasonable to me. Cezary can you take a look and confirm this will not negatively affect existing workqueue metrics for l4. \assign @cezarygerard |
it looks good /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, gauravkghildiyal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…elease-1.22 [Cherry pick #1981] Add smaller bucket sizes for workqueue metrics
[Cherry-pick #1981 -> 1.20] Add smaller bucket sizes for workqueue metrics
Some events related to NEG workqueues take subsecond time for completion. Having more buckets within the 1 second duration should help estimate us better if the NEG Controller is working as expected -- even a slight increase on these <1 second processing times could drastically effect the overall performance when the NEG Controller is managing too many events.