Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smaller bucket sizes for workqueue metrics #1981

Merged

Conversation

gauravkghildiyal
Copy link
Member

Some events related to NEG workqueues take subsecond time for completion. Having more buckets within the 1 second duration should help estimate us better if the NEG Controller is working as expected -- even a slight increase on these <1 second processing times could drastically effect the overall performance when the NEG Controller is managing too many events.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from aojea February 28, 2023 20:05
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from freehan February 28, 2023 20:05
@k8s-ci-robot
Copy link
Contributor

Hi @gauravkghildiyal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2023
@gauravkghildiyal
Copy link
Member Author

/assign @swetharepakula

@swetharepakula
Copy link
Member

This seems reasonable to me. Cezary can you take a look and confirm this will not negatively affect existing workqueue metrics for l4.

\assign @cezarygerard

@cezarygerard
Copy link
Contributor

it looks good

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, gauravkghildiyal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit fb574b3 into kubernetes:master Mar 2, 2023
@gauravkghildiyal gauravkghildiyal deleted the workqueue-metrics-bucket branch March 6, 2023 18:53
k8s-ci-robot added a commit that referenced this pull request Mar 14, 2023
…elease-1.22

[Cherry pick #1981] Add smaller bucket sizes for workqueue metrics
k8s-ci-robot added a commit that referenced this pull request Sep 6, 2023
[Cherry-pick #1981 -> 1.20]  Add smaller bucket sizes for workqueue metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants