Fix log wrong format argument #1986
Conversation
|
@panslava: GitHub didn't allow me to assign the following users: code-elinka. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/assign @code-elinka |
| @@ -238,7 +238,7 @@ func (l4hc *l4HealthChecks) ensureIPv6Firewall(svc *corev1.Service, namer namer. | |||
| ipv6HCFWName := namer.L4IPv6HealthCheckFirewall(svc.Namespace, svc.Name, isSharedHC) | |||
|
|
|||
| start := time.Now() | |||
| klog.V(2).Infof("Ensuring IPv6 Firewall %s for health check for service %s/%s, health check port %s, shared health check: %t, len(nodeNames): %d", ipv6HCFWName, svc.Namespace, svc.Name, hcPort, isSharedHC, len(nodeNames)) | |||
There was a problem hiding this comment.
Could you please fix other occurencies of %s in the file? For example, line 255
There was a problem hiding this comment.
I think line 255 is fine, or do I miss anything?
problem was that variable hcPort is int, not string, so %s was wrong exactly here...
There was a problem hiding this comment.
True, look at a wrong variable...
| @@ -238,7 +238,7 @@ func (l4hc *l4HealthChecks) ensureIPv6Firewall(svc *corev1.Service, namer namer. | |||
| ipv6HCFWName := namer.L4IPv6HealthCheckFirewall(svc.Namespace, svc.Name, isSharedHC) | |||
|
|
|||
| start := time.Now() | |||
| klog.V(2).Infof("Ensuring IPv6 Firewall %s for health check for service %s/%s, health check port %s, shared health check: %t, len(nodeNames): %d", ipv6HCFWName, svc.Namespace, svc.Name, hcPort, isSharedHC, len(nodeNames)) | |||
There was a problem hiding this comment.
True, look at a wrong variable...
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: code-elinka, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @code-elinka
one more time to remind that linters are needed...