Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update duplicate endpoint handling #1994

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Update duplicate endpoint handling #1994

merged 1 commit into from
Mar 14, 2023

Conversation

sawsa307
Copy link
Contributor

@sawsa307 sawsa307 commented Mar 9, 2023

When we encounter duplicate endpoints, we would always choose the one with an alphabetically lower name so we have a consistent and reliable way to break the tie.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and bowei March 9, 2023 22:07
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 9, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sawsa307. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 9, 2023
@sawsa307
Copy link
Contributor Author

sawsa307 commented Mar 9, 2023

/assign @swetharepakula

@swetharepakula
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 11, 2023
swetharepakula
swetharepakula reviewed Mar 11, 2023
View reviewed changes
pkg/neg/syncers/utils.go Outdated
if _, contains := networkEndpointPodMap[networkEndpoint]; contains {
dupCount += 1
existingPod, contains := networkEndpointPodMap[networkEndpoint]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the same call is being made in line 276. Instead just set existingPod there

@sawsa307
Update duplicate endpoint handling
d3403af 
When we encounter duplicate endpoints, we would always choose the one
with an alphabetically lower name so we have a consistent and reliable
way to break the tie.
@sawsa307 sawsa307 force-pushed the change-duplicate-endpoints branch from 9849b5a to d3403af Compare March 11, 2023 00:45
@sawsa307 sawsa307 requested review from swetharepakula and removed request for bowei and aojea March 11, 2023 00:46
swetharepakula
swetharepakula reviewed Mar 14, 2023
View reviewed changes
Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sawsa307, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8e12b93 into kubernetes:master Mar 14, 2023
@sawsa307 sawsa307 deleted the change-duplicate-endpoints branch September 2, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swetharepakula swetharepakula swetharepakula left review comments

Assignees

@swetharepakula swetharepakula

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sawsa307 @k8s-ci-robot @swetharepakula