Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change naming of SSL certs #200

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Change naming of SSL certs #200

merged 1 commit into from
Apr 11, 2018

Conversation

nicksardo
Copy link
Contributor

@nicksardo nicksardo commented Apr 10, 2018 •
edited
Loading

Changes

  • Rename SSL certs from k8s-ssl-{nameHash}--{clusterId}-{secretHash} to k8s-ssl-{nameHash}-{secretHash}--{clusterId} to be consistent with other resources.
  • Get rid of sslCertPrefix for simplification.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2018
@nicksardo nicksardo force-pushed the change-naming-order branch from 29e2ed2 to 9e74eae Compare April 10, 2018 20:37
@nicksardo nicksardo force-pushed the change-naming-order branch from 9e74eae to 9a0fc14 Compare April 11, 2018 15:57
@nicksardo nicksardo requested review from MrHohn and rramkumar1 April 11, 2018 15:58
@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2018
@nicksardo
Copy link
Contributor Author

Thanks.

@nicksardo nicksardo merged commit b40702c into kubernetes:master Apr 11, 2018
@rramkumar1 rramkumar1 mentioned this pull request Apr 27, 2018
Closed
@prameshj prameshj mentioned this pull request Jun 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn Awaiting requested review from MrHohn

@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@rramkumar1 rramkumar1

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicksardo @rramkumar1 @k8s-ci-robot