Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PublishL4NetLBDualStackSyncLatency #2006

Merged

Conversation

panslava
Copy link
Contributor

@panslava panslava commented Mar 13, 2023

Order of execution was wrong, function was fast returned

and some small logs improvements

/assign aojea

@k8s-ci-robot
Copy link
Contributor

@panslava: GitHub didn't allow me to assign the following users: elinka.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Order of execution was wrong, function was fast returned

/assign aojea
/assign elinka

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and MrHohn March 13, 2023 15:30
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 13, 2023
@panslava
Copy link
Contributor Author

/assign @code-elinka

@panslava
Copy link
Contributor Author

/retest

@panslava panslava force-pushed the fix-netlb-dualstack-latency branch from 773a516 to 39e3099 Compare March 13, 2023 16:25
@code-elinka
Copy link
Contributor

Do you know what happened to the workflow?

@aojea
Copy link
Member

aojea commented Mar 14, 2023

/lgtm
/approve
/retest
there is some CI isues beceause is code freeze and the CI cluster is overwhelmed

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fcdd7d6 into kubernetes:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants