Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate nodeport translation #206

Merged
merged 1 commit into from
Apr 11, 2018
Merged

Remove duplicate nodeport translation #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions pkg/controller/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,13 +307,8 @@ func (lbc *LoadBalancerController) sync(key string) (retErr error) {
return err
}

// Get all service ports for the ingress being synced.
lbSvcPorts := lbc.Translator.ToNodePorts(&extensions.IngressList{
Items: []extensions.Ingress{*ing},
})

// Create the backend services and higher-level LB resources.
if err = lbc.CloudClusterManager.EnsureLoadBalancer(lb, lbSvcPorts, igs); err != nil {
if err = lbc.CloudClusterManager.EnsureLoadBalancer(lb, ingNodePorts, igs); err != nil {
return err
}

Expand All @@ -330,7 +325,7 @@ func (lbc *LoadBalancerController) sync(key string) (retErr error) {

// If NEG enabled, link the backend services to the NEGs.
if lbc.negEnabled {
for _, svcPort := range lbSvcPorts {
for _, svcPort := range ingNodePorts {
if svcPort.NEGEnabled {
zones, err := lbc.Translator.ListZones()
if err != nil {
Expand Down