-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support IG backends removal in regional_ig_linker.go. #2067
Support IG backends removal in regional_ig_linker.go. #2067
Conversation
Hi @mmamczur. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1e2c564
to
ee5c570
Compare
ee5c570
to
558cb4d
Compare
/ok-to-test |
code looks good to me, but still want @swetharepakula to take a look, I am not sure, if we should remove instance groups, and why it was not done before (in ig_linker.go as well) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmamczur, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…regional_ig_linker.go.
Tried to make it so that whatever exists in the backends list is preserved instead of overwriting with 'wantIGs'.