Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IG backends removal in regional_ig_linker.go. #2067

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

mmamczur
Copy link
Contributor

@mmamczur mmamczur commented Apr 5, 2023

Tried to make it so that whatever exists in the backends list is preserved instead of overwriting with 'wantIGs'.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mmamczur. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2023
@mmamczur mmamczur force-pushed the ig-linker-backend-removal branch from 1e2c564 to ee5c570 Compare April 6, 2023 15:00
@mmamczur mmamczur force-pushed the ig-linker-backend-removal branch from ee5c570 to 558cb4d Compare April 6, 2023 15:36
@bowei
Copy link
Member

bowei commented Apr 6, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 6, 2023
@panslava
Copy link
Contributor

panslava commented Apr 6, 2023

code looks good to me, but still want @swetharepakula to take a look, I am not sure, if we should remove instance groups, and why it was not done before (in ig_linker.go as well)

Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit b42a7b0 into kubernetes:master Apr 7, 2023
mmamczur added a commit to mmamczur/ingress-gce that referenced this pull request Apr 13, 2023
k8s-ci-robot added a commit that referenced this pull request Apr 13, 2023
[Cherry-pick #2063, #2067 to 1.22] Fix a case when regional instance group l…
@mmamczur mmamczur deleted the ig-linker-backend-removal branch April 10, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants