Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hack script for e2e test image building #2121

Merged
merged 1 commit into from
May 17, 2023
Merged

Use hack script for e2e test image building #2121

merged 1 commit into from
May 17, 2023

Conversation

code-elinka
Copy link
Contributor

The e2e image needs to be built with docker buildx because it may be built in a cross-compiled way
and it has not only pre-copied binaries but also
some dependencies (sh script, curl, gcloud-cli).

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and kl52752 May 17, 2023 08:54
@code-elinka
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2023
@code-elinka
Copy link
Contributor Author

/meow
/assign @aojea
/assign @cezarygerard

@k8s-ci-robot
Copy link
Contributor

@code-elinka: cat image

In response to this:

/meow
/assign @aojea
/assign @cezarygerard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aojea
aojea reviewed May 17, 2023
View reviewed changes
cloudbuild.yaml Outdated Show resolved Hide resolved
aojea
aojea reviewed May 17, 2023
View reviewed changes
cloudbuild.yaml Show resolved Hide resolved
@code-elinka code-elinka force-pushed the cezarys-change branch 3 times, most recently from 8a4b220 to 28b0783 Compare May 17, 2023 12:51
@code-elinka code-elinka requested a review from aojea May 17, 2023 13:02
@code-elinka
Copy link
Contributor Author

/hold Cloudbuild treats "e2e-test" not like Dockerfile.e2e-test but Dockerfile."e2e-test"... ooh

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2023
@code-elinka
Copy link
Contributor Author

/hold Cloudbuild treats "e2e-test" not like Dockerfile.e2e-test but Dockerfile."e2e-test"... ooh

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 17, 2023
@code-elinka
Copy link
Contributor Author

/assign @mmamczur

@k8s-ci-robot
Copy link
Contributor

@code-elinka: GitHub didn't allow me to assign the following users: mmamczur.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mmamczur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2023
@code-elinka
Use hack script for e2e test image building
601393b 
The e2e image needs to be built with docker buildx
because it may be built in a cross-compiled way
and it has not only pre-copied binaries but also
some dependencies (sh script, curl, gcloud-cli).

Signed-off-by: Elina Akhmanova <elinka@google.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2023
@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, code-elinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit bc34d38 into kubernetes:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kl52752 kl52752 Awaiting requested review from kl52752

@aojea aojea Awaiting requested review from aojea

Assignees

@cezarygerard cezarygerard

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@code-elinka @k8s-ci-robot @cezarygerard @aojea