-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only one buildx command for e2e-test #2123
Conversation
/assign @cezarygerard /meow |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@code-elinka: GitHub didn't allow me to assign the following users: mmamczur. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
073f7cf
to
6736260
Compare
6736260
to
a66faeb
Compare
a66faeb
to
3246298
Compare
3246298
to
b40b3c3
Compare
1) Docker buildx cmd can build a multiarch image in one run. Use it instead of many commands 2) The hack/push-multiarch.sh script is used for e2e build via docker buildx (/root/.docker/cli-plugins/docker-buildx). It requires to specify HOME=/root so buildx works as expected. See: github.com/kubernetes/test-infra/tree/master/config/jobs/image-pushing Signed-off-by: Elina Akhmanova <elinka@google.com>
b40b3c3
to
0bc498e
Compare
/unhold |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, code-elinka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
in one run. Use it instead of many commands
via docker buildx (/root/.docker/cli-plugins/docker-buildx).
It requires to specify HOME=/root so buildx works as expected.
See:
github.com/kubernetes/test-infra/tree/master/config/jobs/image-pushing