Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset L4 DualStack Gauge metrics before exporting #2131

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Reset L4 DualStack Gauge metrics before exporting #2131

merged 1 commit into from
Jun 2, 2023

Conversation

panslava
Copy link
Contributor

Now, if service does not exist anymore, it will not be zeroed in metrics

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and code-elinka May 19, 2023 22:28
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 19, 2023
@panslava
Copy link
Contributor Author

/assign @cezarygerard

@panslava panslava changed the title Set L4 DualStack Gauage metrics to default 0 Set L4 DualStack Gauge metrics to default 0 May 21, 2023
@panslava
Copy link
Contributor Author

/retest

cezarygerard
cezarygerard reviewed May 21, 2023
View reviewed changes
pkg/metrics/metrics.go Outdated Show resolved Hide resolved
pkg/metrics/l4metrics_test.go Outdated Show resolved Hide resolved
pkg/metrics/l4metrics_test.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 22, 2023
@panslava
Copy link
Contributor Author

/hold

I will squash commits after lgtm

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2023
@cezarygerard
Copy link
Contributor

just use Reset() method on gave metrics :-D

@panslava
Copy link
Contributor Author

@cezarygerard I changed, now using Reset

@panslava panslava changed the title Set L4 DualStack Gauge metrics to default 0 Reset L4 DualStack Gauge metrics before exporting May 22, 2023
@cezarygerard
Copy link
Contributor

/lgtm

good job in refactoring
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2023
@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cezarygerard,panslava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@panslava
Copy link
Contributor Author

panslava commented Jun 2, 2023

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 016a3da into kubernetes:master Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezarygerard cezarygerard cezarygerard left review comments

@aojea aojea Awaiting requested review from aojea

@code-elinka code-elinka Awaiting requested review from code-elinka

Assignees

@cezarygerard cezarygerard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panslava @cezarygerard @k8s-ci-robot