-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove running tests with verbose mode #2132
Conversation
We have too many logs in all tests
@panslava: GitHub didn't allow me to assign the following users: gauravkghildiyal. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
that is on purpose, otherwise how do you debug the failures? |
@aojea how it works, at least for me, without -v it will print logs for the tests that failed, but not for all of the tests |
your tests show (cached), you need to use |
indeed
so I think is a matter of taste then https://grep.app/search?q=go%20test%20-v&filter[lang][0]=Go, I like to run verbose on CI but I can't see any other reason to not do it, up to you then |
Oh. For me the problem comes when I run make test locally, it is impossible to check logs in terminal. Maybe I can add verbosity only for prow
|
/lgtm it is ok |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, panslava The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have too many logs in all tests
/assign @aojea @swetharepakula @gauravkghildiyal