Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove running tests with verbose mode #2132

Merged
merged 1 commit into from
May 23, 2023

Conversation

panslava
Copy link
Contributor

We have too many logs in all tests

/assign @aojea @swetharepakula @gauravkghildiyal

We have too many logs in all tests
@k8s-ci-robot
Copy link
Contributor

@panslava: GitHub didn't allow me to assign the following users: gauravkghildiyal.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

We have too many logs in all tests

/assign @aojea @swetharepakula @gauravkghildiyal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 19, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and code-elinka May 19, 2023 22:40
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 19, 2023
@aojea
Copy link
Member

aojea commented May 20, 2023

that is on purpose, otherwise how do you debug the failures?

@panslava
Copy link
Contributor Author

@aojea how it works, at least for me, without -v it will print logs for the tests that failed, but not for all of the tests

image

@aojea
Copy link
Member

aojea commented May 23, 2023

your tests show (cached), you need to use -count 1 to not run the cached test

@aojea
Copy link
Member

aojea commented May 23, 2023

indeed -v logs everything

        -v
            Verbose output: log all tests as they are run. Also print all
            text from Log and Logf calls even if the test succeeds.

so I think is a matter of taste then https://grep.app/search?q=go%20test%20-v&filter[lang][0]=Go,

I like to run verbose on CI but I can't see any other reason to not do it, up to you then

@aojea aojea removed their request for review May 23, 2023 07:03
@aojea aojea removed their assignment May 23, 2023
@panslava
Copy link
Contributor Author

panslava commented May 23, 2023 via email

@aojea
Copy link
Member

aojea commented May 23, 2023

/lgtm

it is ok

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2373321 into kubernetes:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants