Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset gauges when collecting service metrics #2136

Merged
merged 1 commit into from
May 22, 2023

Conversation

cezarygerard
Copy link
Contributor

otherwise deleted services will appear in metrics forever it their label combination was unique

otherwise deleted services will appear in metrics forever it their label combination was unique
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 22, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and code-elinka May 22, 2023 09:21
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2023
@cezarygerard
Copy link
Contributor Author

/assign @panslava

@cezarygerard
Copy link
Contributor Author

/assign @aojea

@cezarygerard
Copy link
Contributor Author

/assign @mmamczur

@k8s-ci-robot
Copy link
Contributor

@cezarygerard: GitHub didn't allow me to assign the following users: mmamczur.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mmamczur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@code-elinka
Copy link
Contributor

@cezarygerard
just a nitpick to replace otherwise deleted services will appear in metrics forever it their label combination was unique with otherwise deleted services will appear in metrics forever IF their label combination was unique.

Looks good to me.

@code-elinka
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, code-elinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6b74806 into kubernetes:master May 22, 2023
@mmamczur
Copy link
Contributor

weren't we concerned before that this can make the metrics show 0 if collected at a bad moment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants