-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reset gauges when collecting service metrics #2136
Conversation
otherwise deleted services will appear in metrics forever it their label combination was unique
/assign @panslava |
/assign @aojea |
/assign @mmamczur |
@cezarygerard: GitHub didn't allow me to assign the following users: mmamczur. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@cezarygerard Looks good to me. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cezarygerard, code-elinka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weren't we concerned before that this can make the metrics show 0 if collected at a bad moment? |
otherwise deleted services will appear in metrics forever it their label combination was unique