Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiarch echo image for e2e tests #2139

Merged
merged 1 commit into from
May 24, 2023

Conversation

code-elinka
Copy link
Contributor

To run some of the e2e tests we need an echo
image, therefore we want both of them be
multiarch.
NB! The Windows image doesn't support multiarch.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and prameshj May 23, 2023 17:13
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2023
@code-elinka
Copy link
Contributor Author

/cc @mmamczur
/assign @cezarygerard
/assign @gauravkghildiyal
/meow

@k8s-ci-robot
Copy link
Contributor

@code-elinka: cat image

In response to this:

/cc @mmamczur
/assign @cezarygerard
/assign @gauravkghildiyal
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@code-elinka: GitHub didn't allow me to assign the following users: gauravkghildiyal.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/cc @mmamczur
/assign @cezarygerard
/assign @gauravkghildiyal
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@code-elinka: GitHub didn't allow me to request PR reviews from the following users: mmamczur.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @mmamczur
/assign @cezarygerard
/assign @gauravkghildiyal
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2023
To run some of the e2e tests we need an echo
image, therefore we want both of them be
multiarch.
NB! The Windows image doesn't support multiarch.

Signed-off-by: Elina Akhmanova <elinka@google.com>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2023
@gauravkghildiyal
Copy link
Member

LGTM

@cezarygerard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, code-elinka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9725d7d into kubernetes:master May 24, 2023
@code-elinka code-elinka deleted the new-arm-round branch August 10, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants