Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin golang patch version in Makefile #2140

Merged
merged 1 commit into from
May 23, 2023

Conversation

code-elinka
Copy link
Contributor

Patches of golang could differ and
make the debugging process harder.
To demolish that problem we should
pin not only major.minor versions
but also patch one.

@cezarygerard I decided to proceed with patch, not sha because it's more readable and can be used in any basic image.
image
see: https://hub.docker.com/_/golang

Patches of golang could differ and
make the debugging process harder.
To demolish that problem we should
pin not only major.minor versions
but also patch one.

Signed-off-by: GitHub <noreply@github.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 23, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and freehan May 23, 2023 18:16
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 23, 2023
@code-elinka
Copy link
Contributor Author

/assign @gauravkghildiyal
/assign @cezarygerard
/ok-to-test
/meow

@k8s-ci-robot
Copy link
Contributor

@code-elinka: cat image

In response to this:

/assign @gauravkghildiyal
/assign @cezarygerard
/ok-to-test
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

@code-elinka: GitHub didn't allow me to assign the following users: gauravkghildiyal.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gauravkghildiyal
/assign @cezarygerard
/ok-to-test
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gauravkghildiyal
Copy link
Member

Thanks @code-elinka!
LGTM

Copy link
Member

@swetharepakula swetharepakula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: code-elinka, swetharepakula

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7d9c4fc into kubernetes:master May 23, 2023
@code-elinka code-elinka deleted the pin-go-version branch May 23, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants