-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin golang patch version in Makefile #2140
Conversation
Patches of golang could differ and make the debugging process harder. To demolish that problem we should pin not only major.minor versions but also patch one. Signed-off-by: GitHub <noreply@github.com>
/assign @gauravkghildiyal |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@code-elinka: GitHub didn't allow me to assign the following users: gauravkghildiyal. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @code-elinka! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: code-elinka, swetharepakula The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Patches of golang could differ and
make the debugging process harder.
To demolish that problem we should
pin not only major.minor versions
but also patch one.
@cezarygerard I decided to proceed with patch, not sha because it's more readable and can be used in any basic image.
see: https://hub.docker.com/_/golang