Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reserve Static IPv6 address before syncing L4 NetLB #2165

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Reserve Static IPv6 address before syncing L4 NetLB #2165

merged 2 commits into from
Jun 28, 2023

Conversation

panslava
Copy link
Contributor

@panslava panslava commented Jun 8, 2023

This will prevent losing address while recreating forwarding rule

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 8, 2023
@k8s-ci-robot k8s-ci-robot requested review from aojea and code-elinka June 8, 2023 22:12
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 8, 2023
@panslava panslava mentioned this pull request Jun 21, 2023
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2023
@panslava panslava force-pushed the reserve-netlb-ipv6 branch from 6c37b1a to 3d8733b Compare June 22, 2023 22:13
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 22, 2023
@panslava panslava force-pushed the reserve-netlb-ipv6 branch from 3d8733b to a48e2f0 Compare June 22, 2023 23:24
@panslava panslava changed the title [WIP] Reserve Static IPv6 address before syncing L4 NetLB Reserve Static IPv6 address before syncing L4 NetLB Jun 22, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2023
@panslava
Copy link
Contributor Author

/assign @cezarygerard

@panslava panslava force-pushed the reserve-netlb-ipv6 branch from a48e2f0 to a57af6b Compare June 22, 2023 23:30
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2023
cezarygerard
cezarygerard reviewed Jun 27, 2023
View reviewed changes
pkg/loadbalancers/l4netlb_test.go Outdated Show resolved Hide resolved
pkg/loadbalancers/l4netlb_test.go Outdated Show resolved Hide resolved
pkg/loadbalancers/l4netlb_test.go Outdated Show resolved Hide resolved
pkg/loadbalancers/l4netlb_test.go Outdated Show resolved Hide resolved
panslava added 2 commits June 28, 2023 01:13
@panslava
Reserve Static IPv6 address before syncing L4 NetLB
c7daf26 
This will prevent losing address while recreating forwarding rule
@panslava
Apply review comments
9cc2680
@panslava panslava force-pushed the reserve-netlb-ipv6 branch from a57af6b to 9cc2680 Compare June 28, 2023 01:18
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2023
@cezarygerard
Copy link
Contributor

cezarygerard commented Jun 28, 2023 •
edited
Loading

/lgtm

thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cezarygerard, panslava

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cezarygerard,panslava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9ddf359 into kubernetes:master Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezarygerard cezarygerard cezarygerard left review comments

@aojea aojea Awaiting requested review from aojea

@code-elinka code-elinka Awaiting requested review from code-elinka

Assignees

@cezarygerard cezarygerard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panslava @cezarygerard @k8s-ci-robot