-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update annotations.md #221
Conversation
This documentation mistakingly implies the prefix for `pre-shared-cert` is `ingress.kubernetes.io`, when it is actually `ingress.gcp.kubernetes.io`. Using the former will not create an HTTPS mapping in the GCLB, and does not emit any errors indicating there is an issue with the annotation.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @buzzedword. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CLA has been signed. |
/lgtm |
This documentation mistakingly implies the prefix for
pre-shared-cert
isingress.kubernetes.io
, when it is actuallyingress.gcp.kubernetes.io
. Using the former will not create an HTTPS mapping in the GCLB, and does not emit any errors indicating there is an issue with the annotation.