BackendService naming for NEG backend services & healthchecks #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
reviewed
May 10, 2018
pkg/loadbalancers/l7.go
Outdated
| @@ -137,7 +137,7 @@ func (l *L7) checkUrlMap() (err error) { | |||
| if l.runtimeInfo.UrlMap == nil { | |||
| return fmt.Errorf("cannot create urlmap without internal representation") | |||
| } | |||
| defaultBackendName := l.namer.Backend(l.runtimeInfo.UrlMap.DefaultBackend.NodePort) | |||
| defaultBackendName := l.namer.IGBackend(l.runtimeInfo.UrlMap.DefaultBackend.NodePort) | |||
There was a problem hiding this comment.
How come you use IGBackend() directly here instead of ServicePort.BackendName()?
nicksardo
force-pushed
the
backendsvc-naming
branch
from
7571409 to
5c1b13d
Compare
|
Manual test looked good. Nice job @agau4779 |
|
Looks fine to me. Will leave @freehan to give LGTM. |
freehan
reviewed
May 11, 2018
pkg/utils/namer.go
Outdated
| @@ -239,13 +247,13 @@ func (n *Namer) NameBelongsToCluster(name string) bool { | |||
| return components.ClusterName == clusterName || n.negBelongsToCluster(name) | |||
| } | |||
|
|
|||
| // BeName constructs the name for a backend. | |||
| func (n *Namer) Backend(port int64) string { | |||
| // IGBackend constructs the name for a backend. | |||
There was a problem hiding this comment.
comment: IGBackend constructs the name for a backend service targeting instance groups.
pkg/utils/namer.go
Outdated
| // negBelongsToCluster checks that the uid is present and a substring of the | ||
| // cluster uid, since the NEG naming schema truncates it to 8 characters. | ||
| // This is only valid for NEGs and Backends on NEG. | ||
| func (n *Namer) negBelongsToCluster(name string) bool { |
There was a problem hiding this comment.
nit: negNameBelongsToCluster?
comment: This is only valid for NEGs, BackendServices and Healthchecks for NEG
nicksardo
force-pushed
the
backendsvc-naming
branch
from
5c1b13d to
06db5a4
Compare
|
Thanks for both of your reviews. Fixed comments. |
nicksardo
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #239
More changes:
namer.Backendis renamed tonamer.IGBackendto prevent confusion between IG/NEG.TODO in another PR:
Rewrite unit tests to not care what kind of serviceport their given.