Pass service/port tuple separate from ServicePort #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
reviewed
May 15, 2018
| return nil | ||
| } | ||
| negName := b.namer.NEG(port.SvcName.Namespace, port.SvcName.Name, port.SvcTargetPort) | ||
| negName := b.namer.NEG(sp.ID.Service.Namespace, sp.ID.Service.Name, sp.SvcTargetPort) |
There was a problem hiding this comment.
Can we use the new BackendName function here?
There was a problem hiding this comment.
So this name is used for both the NEG and the BackendService. I'll be redundantly clear and use BackendName for when we get the backendservice; however, I think this line is still appropriate for the NEG.
| urlMap := lbc.Translator.TranslateIngress(ing, lbc.CloudClusterManager.defaultBackendSvcPort) | ||
| urlMap, err := lbc.Translator.TranslateIngress(ing, lbc.CloudClusterManager.defaultBackendSvcPortID) | ||
| if err != nil { | ||
| return fmt.Errorf("error while evaluating the ingress spec: %v", err) |
pkg/flags/flags.go
Outdated
| @@ -103,8 +104,10 @@ controller only works with default zones.`) | |||
| must serve a 200 page on this path.`) | |||
There was a problem hiding this comment.
I would maybe add one line that says that default-backend-service and default-backend-service-port are mandatory.
pkg/utils/serviceport.go
Outdated
| return namer.NEG(sp.ID.Service.Namespace, sp.ID.Service.Name, sp.SvcTargetPort) | ||
| } | ||
|
|
||
| // BackendToServicePortID creates a ServicePortID struct from an IngressBackend struct and namespace. |
There was a problem hiding this comment.
Nit: Remove the word struct from the comment.
| @@ -62,6 +63,18 @@ func IsHTTPErrorCode(err error, code int) bool { | |||
| return ok && apiErr.Code == code | |||
| } | |||
|
|
|||
| // ToNamespacedName returns a types.NamespacedName struct parsed from namespace/name. | |||
| func ToNamespacedName(s string) (r types.NamespacedName, err error) { | |||
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
Fixed a small typo in the test. |
nicksardo
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: