Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure structs in OpenAPI spec are serialized with 'type: object' #283

Merged
merged 1 commit into from
May 23, 2018
Merged

Make sure structs in OpenAPI spec are serialized with 'type: object' #283

merged 1 commit into from
May 23, 2018

Conversation

rramkumar1
Copy link
Contributor

This will ensure that if a user pushes a spec like below, that an error will be returned to them:

spec:
  iap:

/assign @MrHohn

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 23, 2018
MrHohn
MrHohn approved these changes May 23, 2018
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2018
@rramkumar1
Copy link
Contributor Author

/assign @nicksardo

@nicksardo nicksardo merged commit d2c6fdd into kubernetes:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

Assignees

@nicksardo nicksardo

@MrHohn MrHohn

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rramkumar1 @MrHohn @nicksardo @k8s-ci-robot