Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IngressValidator and supporting utilities #300

Merged
merged 1 commit into from
Jun 5, 2018

Conversation

bowei
Copy link
Member

@bowei bowei commented Jun 4, 2018

This adds a reusability Ingress spec testing utility. The vanilla
features of Ingress are tested with IngressValidator. Additional addon
features are supported by extending the validator with the Feature
modules in the features/ package.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 4, 2018
@rramkumar1
Copy link
Contributor

rramkumar1 commented Jun 4, 2018

@bowei The unit test is failing on the vendor. I think you should use github.com/kr/pretty instead since now that is vendored in.

@bowei bowei force-pushed the validator branch 3 times, most recently from 4f37736 to 60d6f0b Compare June 5, 2018 19:45
This adds a reusable Ingress spec testing utility. The vanilla features
of Ingress are tested with IngressValidator. Additional addon features
are supported by extending the validator with the Feature modules in the
features/ package.
@bowei bowei merged commit 2a805f5 into kubernetes:master Jun 5, 2018
@bowei bowei deleted the validator branch June 10, 2018 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants