Use generated mocks to implement unit tests for pkg/backends #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
rramkumar1
changed the title
|
/assign @nicksardo |
nicksardo
reviewed
Jun 5, 2018
pkg/backends/backends_test.go
Outdated
| } | ||
| } | ||
|
|
||
| func TestRetrieveObjectName(t *testing.T) { |
There was a problem hiding this comment.
Can you move these funcs back to there original position so my PR won't conflict as much?
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates the gce generated mocks into pkg/backends.
This PR vendors k/pkg/cloudprovider/providers/gce/cloud/mock and there are two raw patches to the vendored code which will need to be upstreamed at some point:
This change is