Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta backend service support to composite type #310

Merged
merged 2 commits into from
Jun 6, 2018

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented Jun 5, 2018

/assign @rramkumar1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 5, 2018
@rramkumar1
Copy link
Contributor

@MrHohn Can you link the corresponding PR in k/k for the vendored code?

@MrHohn
Copy link
Member Author

MrHohn commented Jun 5, 2018

Sure, that is kubernetes/kubernetes#64793.

@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 5, 2018
@rramkumar1
Copy link
Contributor

/assign @nicksardo

@MrHohn MrHohn changed the title Add beta backend service support to compotie type Add beta backend service support to composite type Jun 5, 2018
@nicksardo
Copy link
Contributor

Is there a PR for updating the generated client?

@rramkumar1
Copy link
Contributor

rramkumar1 commented Jun 6, 2018 via email

@nicksardo
Copy link
Contributor

Sorry, blind.

@nicksardo nicksardo merged commit 169e8d6 into kubernetes:master Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants