Break out some helper functions for better testing + reuse #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
rramkumar1
changed the title
k8s-ci-robot
added
the
size/L
MrHohn
approved these changes
Jun 7, 2018
| "k8s.io/ingress-gce/pkg/annotations" | ||
| ) | ||
|
|
||
| func TestBackendConfigName(t *testing.T) { |
There was a problem hiding this comment.
Might be worth to have a test case where both default and ports are given and check the ports one takes precedence?
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation behind this change is to be able to reuse these new utility functions in our new testing framework. Also, breaking these functions out make them easier to test.
/assign @nicksardo
/assign @MrHohn
This change is