Patch NEG version into features.go and add more docs for features package #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrHohn: GitHub didn't allow me to assign the following users: agau4779. Note that only kubernetes members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
cncf-cla: yes
MrHohn
force-pushed
the
remove-unused-version-caller
branch
from
962ec4d to
37b18c4
Compare
MrHohn
commented
Jun 29, 2018
| (fakeGCE.Compute().(*cloud.MockGCE)).MockBackendServices.InsertHook = func(ctx context.Context, key *meta.Key, be *compute.BackendService, m *cloud.MockBackendServices) (bool, error) { | ||
| return insertFunc(ctx, key, be.Name) | ||
| } | ||
| (fakeGCE.Compute().(*cloud.MockGCE)).MockBetaBackendServices.InsertHook = func(ctx context.Context, key *meta.Key, be *computebeta.BackendService, m *cloud.MockBetaBackendServices) (bool, error) { |
There was a problem hiding this comment.
Added a Beta hook here as well.
k8s-ci-robot
added
the
lgtm
Merged
MrHohn
added a commit
that referenced
this pull request
Jul 9, 2018
Cherrypick #381and #384 into release-1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
func (sp ServicePort) Version() meta.Versionis deprecated, new feature version logic should be added to features.go instead.Still working on fixing the unit test.
/assign @freehan @agau4779