uniq function should compare more than NodePort difference #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
nicksardo
reviewed
Jul 17, 2018
pkg/controller/utils.go
Outdated
| func uniq(svcPorts []utils.ServicePort) []utils.ServicePort { | ||
| portMap := map[string]utils.ServicePort{} | ||
| for _, p := range svcPorts { | ||
| portMap[fmt.Sprintf("%q-%q-%q", p.ID.Service.Namespace, p.ID.Service.Name, p.ID.Port.String())] = p |
There was a problem hiding this comment.
We should probably define a String() for ServicePortID while we're at it.
func (id ServicePortID) String() string {
return fmt.Sprintf("%v/%v", id.Service.String(), id.Port.String())
}
yielding kube-system/default-backend/http
freehan
force-pushed
the
uniq-bug-fix2
branch
3 times, most recently
from
3acbb13 to
a4427d2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
nicksardo
added a commit
that referenced
this pull request
Jul 18, 2018
cherrypick #402 to release-1.2 branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @agau4779