Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not create instance group with NEG backends #440

Merged
merged 1 commit into from
Aug 21, 2018
Merged

do not create instance group with NEG backends #440

merged 1 commit into from
Aug 21, 2018

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Aug 16, 2018 •
edited
Loading

ref: #433

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 16, 2018
@rramkumar1
Copy link
Contributor

rramkumar1 commented Aug 17, 2018 •
edited
Loading

@freehan Aside from the PR, I'm thinking it might be worthwhile to add an e2e test for this in the main k8s repo. Maybe even bake the check into an existing test you have.

rramkumar1
rramkumar1 reviewed Aug 17, 2018
View reviewed changes
pkg/controller/utils.go Outdated

// getNodePortsUsedByIngress returns the list of uniq NodePort from the input ServicePorts.
// Only NonNEG service backend need NodePort.
func getNodePortsUsedByIngress(svcPorts []utils.ServicePort) []int64 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this nodePorts()?

@lbernail
Copy link
Contributor

Thanks! I can test it on our clusters as soon as this is merged to give you feedback

@freehan
Copy link
Contributor Author

freehan commented Aug 17, 2018

Aside from the PR, I'm thinking it might be worthwhile to add an e2e test for this in the main k8s repo. Maybe even bake the check into an existing test you have.

That requires those tests to be serialized though.

@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2018
@k8s-ci-robot k8s-ci-robot merged commit 85266ca into kubernetes:master Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

Assignees

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@freehan @rramkumar1 @lbernail @k8s-ci-robot