Remove 'Description' and 'Required' from OpenAPI schema root layer #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
| @@ -32,7 +32,6 @@ func GetOpenAPIDefinitions(ref common.ReferenceCallback) map[string]common.OpenA | |||
| "k8s.io/ingress-gce/pkg/apis/backendconfig/v1beta1.BackendConfig": { | |||
| Schema: spec.Schema{ | |||
| SchemaProps: spec.SchemaProps{ | |||
| Description: "BackendConfig is a specification for a BackendConfig resource", | |||
There was a problem hiding this comment.
Looks like the description is from line 27 in types.go
There was a problem hiding this comment.
Good catch, let me see if removing that works.
There was a problem hiding this comment.
Yes it works :) Update PR, thanks!
MrHohn
force-pushed
the
remove-desc-required-openapi
branch
from
d9832eb to
e84036f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Aug 21, 2018
Cherrypick #442 into release-1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for fixing an incompatibility issue with kubernetes/enhancements#571.
/assign @rramkumar1
cc @Liujingfang1
Note: TheFixed by removing struct comment.Descriptionentry is manually removed, as addingomitemptydoesn't seem to stop generating it.