Harden NEG GC #459
Merged
Harden NEG GC #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bowei
reviewed
Sep 5, 2018
pkg/neg/controller.go
Outdated
| @@ -41,6 +41,11 @@ import ( | |||
| "k8s.io/ingress-gce/pkg/utils" | |||
| ) | |||
|
|
|||
| const ( | |||
| // gcPeriod is the interval between NEG garbage collection workflows | |||
| gcPeriod = 2 * time.Minute | |||
bowei
reviewed
Sep 6, 2018
pkg/flags/flags.go
Outdated
| @@ -215,6 +216,8 @@ L7 load balancing. CSV values accepted. Example: -node-port-ranges=80,8080,400-5 | |||
| `This flag is deprecated. Use -v to control verbosity.`) | |||
| flag.Bool("use-real-cloud", false, | |||
| `This flag has been deprecated and no longer has any effect.`) | |||
| flag.DurationVar(&F.GCPeriod, "gc-period", 120*time.Second, | |||
| `Relist and garbage collect cloud resources this often.`) | |||
There was a problem hiding this comment.
isn't this just for NEG? (the description is a little misleading...)
|
ping |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified 2 things: