Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pkg/common/operator & pkg/common/typed to make resource joins much cleaner. #517

Merged
merged 3 commits into from
Nov 26, 2018
Merged

Add pkg/common/operator & pkg/common/typed to make resource joins much cleaner. #517

merged 3 commits into from
Nov 26, 2018

Conversation

rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Oct 19, 2018 •
edited
Loading

/assign @bowei

PR is broken up into 3 commits for easier review.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 19, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin October 19, 2018 21:19
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 19, 2018
@rramkumar1 rramkumar1 changed the title Add pkg/operator & pkg/types to make resource joins much cleaner. Add pkg/common/operator & pkg/common/types to make resource joins much cleaner. Oct 19, 2018
@rramkumar1 rramkumar1 force-pushed the use-operator-pattern branch from 2918f85 to 8b39415 Compare October 19, 2018 21:33
@rramkumar1
Copy link
Contributor Author

/cc @agau4779

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: GitHub didn't allow me to request PR reviews from the following users: agau4779.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @agau4779

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rramkumar1 rramkumar1 changed the title Add pkg/common/operator & pkg/common/types to make resource joins much cleaner. Add pkg/common/operator & pkg/common/typed to make resource joins much cleaner. Oct 19, 2018
@rramkumar1 rramkumar1 force-pushed the use-operator-pattern branch from 8b39415 to c4ca801 Compare November 5, 2018 21:05
@rramkumar1 rramkumar1 force-pushed the use-operator-pattern branch from c4ca801 to b357d0c Compare November 5, 2018 21:10
@bowei
Copy link
Member

bowei commented Nov 26, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab3d9e5 into kubernetes:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rramkumar1 @k8s-ci-robot @bowei