Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Managed Certs integration: Fix code so that informers are not instantiated if managed certs is not enabled #529

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Managed Certs integration: Fix code so that informers are not instantiated if managed certs is not enabled #529

merged 1 commit into from
Oct 30, 2018

Conversation

rramkumar1
Copy link
Contributor

This should fix the current failures in the OSS CI:

Ref: https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-ingress-gce-e2e/3251

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 30, 2018
@rramkumar1
Copy link
Contributor Author

cc @krzykwas

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 30, 2018
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin October 30, 2018 22:41
@prameshj
Copy link
Contributor

good catch, thanks for fixing. looks good to me.

@rramkumar1
Copy link
Contributor Author

/assign @MrHohn

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2018
MrHohn
MrHohn approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9200ebc into kubernetes:master Oct 30, 2018
@krzykwas
Copy link
Contributor

Sorry for this bug and many thanks for fixing that, rramkumar1@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rramkumar1 @prameshj @k8s-ci-robot @krzykwas @MrHohn