Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress e2e test cleanup #577

Merged
merged 3 commits into from
Dec 11, 2018
Merged

Ingress e2e test cleanup #577

merged 3 commits into from
Dec 11, 2018

Conversation

agau4779
Copy link
Contributor

  • Start and stop ConfigMap informer based on k8s master state
  • Delete Ingress and break loop upon test finish

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @agau4779. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2018
@agau4779
Copy link
Contributor Author

/assign @rramkumar1

rramkumar1
rramkumar1 reviewed Dec 11, 2018
View reviewed changes
pkg/e2e/status.go Outdated
cm *v1.ConfigMap
f *Framework
stopCh chan struct{}
hasInformers bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you call this informersRunning.

pkg/e2e/status.go Outdated
f *Framework
cm *v1.ConfigMap
f *Framework
stopCh chan struct{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would call this informerCh to be explicit about where it is used.

pkg/e2e/status.go Outdated

// Restart ConfigMap informer if it was previously shut down
if sm.masterUpgraded() && !sm.hasInformers {
sm.startInformer()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put this new block of code at the beginning of the loop

@agau4779 agau4779 force-pushed the start-stop-informer branch from 05b6744 to 2eccf85 Compare December 11, 2018 19:39
@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 11, 2018
rramkumar1
rramkumar1 reviewed Dec 11, 2018
View reviewed changes
pkg/e2e/status.go Outdated
cm *v1.ConfigMap
f *Framework
informerCh chan struct{}
informersRunning bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: informerRunning

pkg/e2e/status.go Outdated
}
sm.cm = updatedCm
sm.cm.Name = configMapName

// If master is in the process upgrading, we exit early and turn off the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be at the top as well.

pkg/e2e/status.go Outdated

return nil
func (sm *StatusManager) stopInformer() {
glog.V(4).Info("Stopped informers")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you say "Stopped config map informer". Similar for the start func

@agau4779 agau4779 force-pushed the start-stop-informer branch from e2fe20e to eab0328 Compare December 11, 2018 21:20
@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agau4779, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2018
@k8s-ci-robot k8s-ci-robot merged commit fa7203e into kubernetes:master Dec 11, 2018
@agau4779 agau4779 deleted the start-stop-informer branch February 6, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rramkumar1 rramkumar1 rramkumar1 left review comments

@bowei bowei Awaiting requested review from bowei

@thockin thockin Awaiting requested review from thockin

Assignees

@rramkumar1 rramkumar1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agau4779 @k8s-ci-robot @rramkumar1