Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete documentation that is now covered by GCP docs #600

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Jan 8, 2019

Ref: #557

The bulk of the deletions here are happening in examples/ and in docs/annotations.md. All of this is now moved over to the GCP docs (see README.md for the links).

Also note that the new README.md mentions that CHANGELOG.md will contain high-level release notes along with a list of all changes. The high-level release notes will come in another CL.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and thockin January 8, 2019 21:47
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2019
@rramkumar1 rramkumar1 changed the title [WIP] Delete documentation that is now covered by GCP docs Delete documentation that is now covered by GCP docs Jan 8, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2019
@rramkumar1
Copy link
Contributor Author

/assign @steveperry-53
/assign @MrHohn
/assign @freehan
/assign @agau4779
/assign @bowei

@k8s-ci-robot
Copy link
Contributor

@rramkumar1: GitHub didn't allow me to assign the following users: agau4779.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @steveperry-53
/assign @MrHohn
/assign @freehan
/assign @agau4779
/assign @bowei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@steveperry-53
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rramkumar1, steveperry-53

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rramkumar1
Copy link
Contributor Author

/hold
So more people can take a look and LGTM

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit 21a531a into kubernetes:master Jan 8, 2019
@rramkumar1
Copy link
Contributor Author

Oops, looks like I added the hold label too late. Can make changes in a followup if there are any comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants