Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BackendConfig] CDN default cache key policy should be true instead of false. #611

Merged
merged 1 commit into from
Jan 16, 2019
Merged

[BackendConfig] CDN default cache key policy should be true instead of false. #611

merged 1 commit into from
Jan 16, 2019

Conversation

rramkumar1
Copy link
Contributor

@rramkumar1 rramkumar1 commented Jan 15, 2019 •
edited
Loading

Fixes #599

Currently verifying whether this works and other existing state transitions still hold.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2019
@agau4779
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 16, 2019
@rramkumar1
Copy link
Contributor Author

/assign @MrHohn

MrHohn
MrHohn approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to un-hold this when you are done verifying this. Thanks!
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rramkumar1
Copy link
Contributor Author

Verified this works.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2019
@rramkumar1 rramkumar1 merged commit 71a3a75 into kubernetes:master Jan 16, 2019
@rramkumar1 rramkumar1 mentioned this pull request Jan 16, 2019
Merged
@ConradIrwin ConradIrwin mentioned this pull request Jan 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@freehan freehan Awaiting requested review from freehan

@thockin thockin Awaiting requested review from thockin

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rramkumar1 @agau4779 @k8s-ci-robot @MrHohn