Add more unit tests for transaction syncer #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
freehan
force-pushed
the
unit-test
branch
3 times, most recently
from
80dcf37 to
168fe3e
Compare
bowei
reviewed
Jan 29, 2019
pkg/neg/syncers/transaction.go
Outdated
| syncer.SetSyncFunc(ts.sync) | ||
| // Syncer implements life cycle logic | ||
| syncer := newSyncer(negSyncerKey, networkEndpointGroupName, serviceLister, recorder, ts) | ||
| // TransactionSyncer needs syncer interface for internals |
There was a problem hiding this comment.
[minor] isn't transactionSyncer lowercase
pkg/neg/syncers/transaction.go
Outdated
| @@ -285,7 +287,7 @@ func (s *transactionSyncer) commitTransaction(err error, networkEndpointMap map[ | |||
| for encodedEndpoint := range networkEndpointMap { | |||
| entry, ok := s.transactions.Get(encodedEndpoint) | |||
| if !ok { | |||
| glog.Errorf("Endpoint %q was not found in the transaction table.") | |||
| glog.Errorf("Endpoint %q was not found in the transaction table. This is unexpected", encodedEndpoint) | |||
There was a problem hiding this comment.
"This is unexpected" probably not needed (you are already logging an Errorf
| @@ -44,6 +49,293 @@ const ( | |||
| testService = "svc" | |||
| ) | |||
|
|
|||
| func TestTransactionSyncNetworkEndpoints(t *testing.T) { | |||
| fakeGCECloud := gce.FakeGCECloud(gce.DefaultTestClusterValues()) | |||
| } | ||
|
|
||
| func TestCommitTransaction(t *testing.T) { | ||
| s, transactionSyncer := newTestTransactionSyncer(gce.FakeGCECloud(gce.DefaultTestClusterValues())) |
pkg/neg/syncers/transaction_test.go
Outdated
| } | ||
|
|
||
| func (s *testSyncer) Sync() bool { | ||
| s.SyncCount += 1 |
pkg/neg/types/mock.go
Outdated
| type NetworkEndpointStore map[meta.Key][]NetworkEndpointEntry | ||
|
|
||
| func MockNetworkEndpointAPIs(fakeGCE *gce.GCECloud) { | ||
| (fakeGCE.Compute().(*cloud.MockGCE)).MockBetaNetworkEndpointGroups.X = NetworkEndpointStore{} |
There was a problem hiding this comment.
probably shorter to
m := (fakeGCE.Compute().(*cloud.MockGCE)
m.MockBeta... = ...
...
|
Fixed the comments |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.